> From: Jiri Pirko <jiri@xxxxxxxxxxx> > Sent: Tuesday, June 25, 2024 4:37 PM [..] > >So if you are changing that to a completion, I think surprise removal > >needs to trigger a callback so the completion can be signalled. > > What exacly do you mean by "surprise removal"? PCI devices can be removed from the PCI bus while the driver is running and with outstanding admin commands. Pci bus's remove() is called and this needs to notify and complete the outstanding commands with the error ENODEV or similar.