Re: [PATCH V2 3/3] virtio-net: synchronize operstate with admin state on up/down

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jason Wang <jasowang@xxxxxxxxxx>
Subject: Re: [PATCH V2 3/3] virtio-net: synchronize operstate with admin state on up/down
From: "Michael S. Tsirkin" <mst@xxxxxxxxxx>
Date: Tue, 25 Jun 2024 04:32:46 -0400
Cc: xuanzhuo@xxxxxxxxxxxxxxxxx, eperezma@xxxxxxxxxx, davem@xxxxxxxxxxxxx, edumazet@xxxxxxxxxx, kuba@xxxxxxxxxx, pabeni@xxxxxxxxxx, virtualization@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, venkat.x.venkatsubra@xxxxxxxxxx, gia-khanh.nguyen@xxxxxxxxxx
In-reply-to: <CACGkMEtY1waRRWOKvmq36Wxio3tUGbTooTe-QqCMBFVDjOW-8w@mail.gmail.com>
References: <20240624024523.34272-1-jasowang@redhat.com> <20240624024523.34272-4-jasowang@redhat.com> <20240624060057-mutt-send-email-mst@kernel.org> <CACGkMEsysbded3xvU=qq6L_SmR0jmfvXdbthpZ0ERJoQhveZ3w@mail.gmail.com> <20240625031455-mutt-send-email-mst@kernel.org> <CACGkMEt4qnbiotLgBx+jHBSsd-k0UAVSxjHovfXk6iGd6uSCPg@mail.gmail.com> <20240625035638-mutt-send-email-mst@kernel.org> <CACGkMEtY1waRRWOKvmq36Wxio3tUGbTooTe-QqCMBFVDjOW-8w@mail.gmail.com>

On Tue, Jun 25, 2024 at 04:11:05PM +0800, Jason Wang wrote:
> On Tue, Jun 25, 2024 at 3:57 PM Michael S. Tsirkin <mst@xxxxxxxxxx> wrote:
> >
> > On Tue, Jun 25, 2024 at 03:46:44PM +0800, Jason Wang wrote:
> > > Workqueue is used to serialize those so we won't lose any change.
> >
> > So we don't need to re-read then?
> >
> 
> We might have to re-read but I don't get why it is a problem for us.
> 
> Thanks

I don't think each ethtool command should force a full config read,
is what I mean. Only do it if really needed.

-- 
MST

Follow-Ups:
- Re: [PATCH V2 3/3] virtio-net: synchronize operstate with admin state on up/down
  - From: Jason Wang

References:
- [PATCH V2 0/3] virtio-net: synchronize operstate with admin state on up/down
  - From: Jason Wang
- [PATCH V2 3/3] virtio-net: synchronize operstate with admin state on up/down
  - From: Jason Wang
- Re: [PATCH V2 3/3] virtio-net: synchronize operstate with admin state on up/down
  - From: Michael S. Tsirkin
- Re: [PATCH V2 3/3] virtio-net: synchronize operstate with admin state on up/down
  - From: Jason Wang
- Re: [PATCH V2 3/3] virtio-net: synchronize operstate with admin state on up/down
  - From: Michael S. Tsirkin
- Re: [PATCH V2 3/3] virtio-net: synchronize operstate with admin state on up/down
  - From: Jason Wang
- Re: [PATCH V2 3/3] virtio-net: synchronize operstate with admin state on up/down
  - From: Michael S. Tsirkin
- Re: [PATCH V2 3/3] virtio-net: synchronize operstate with admin state on up/down
  - From: Jason Wang

Prev by Date: Re: [PATCH V2 1/3] virtio: allow nested disabling of the configure interrupt
Next by Date: [PATCH] x86/vmware: fix panic in vmware_hypercall_slow()
Previous by thread: Re: [PATCH V2 3/3] virtio-net: synchronize operstate with admin state on up/down
Next by thread: Re: [PATCH V2 3/3] virtio-net: synchronize operstate with admin state on up/down
Index(es):
- Date
- Thread

[Index of Archives] [KVM Development] [Libvirt Development] [Libvirt Users] [CentOS Virtualization] [Netdev] [Ethernet Bridging] [Linux Wireless] [Kernel Newbies] [Security] [Linux for Hams] [Netfilter] [Bugtraq] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux RAID] [Linux Admin] [Samba]