On Thu, 20 Jun 2024 20:39:18 -0700, Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
> On Tue, 18 Jun 2024 10:56:42 +0800 Heng Qi wrote:
> > + if (dev->irq_moder && dev->irq_moder->profile_flags & DIM_PROFILE_RX) {
> > + ret = ethnl_update_profile(dev, &dev->irq_moder->rx_profile,
> > + tb[ETHTOOL_A_COALESCE_RX_PROFILE],
> > + info->extack);
> > + if (ret < 0)
> > + return ret;
> > + }
> > +
> > + if (dev->irq_moder && dev->irq_moder->profile_flags & DIM_PROFILE_TX) {
> > + ret = ethnl_update_profile(dev, &dev->irq_moder->tx_profile,
> > + tb[ETHTOOL_A_COALESCE_TX_PROFILE],
> > + info->extack);
> > + if (ret < 0)
> > + return ret;
> > + }
>
> One last thing - you're missing updating the &mod bit.
> When any of the settings were change mod should be set
> to true so that we send a notification to user space,
> that the settings have been modified.
Oh, I didn't modify the mod bit in the past because the profile list
modification does not require the dual_change behavior, ignoring the
passing of ret = 0/1. Will modify.
Thanks.
