On Wed, 12 Jun 2024 16:20:11 -0700, Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > On Tue, 11 Jun 2024 19:41:33 +0800 Xuan Zhuo wrote: > > +/** > > + * virtqueue_dma_map_page_attrs - map DMA for _vq > > + * @_vq: the struct virtqueue we're talking about. > > + * @page: the page to do dma > > + * @offset: the offset inside the page > > + * @size: the size of the page to do dma > > + * @dir: DMA direction > > + * @attrs: DMA Attrs > > + * > > + * The caller calls this to do dma mapping in advance. The DMA address can be > > + * passed to this _vq when it is in pre-mapped mode. > > + * > > + * return DMA address. Caller should check that by virtqueue_dma_mapping_error(). > > You gotta format the return value doc in a kdoc-sanctioned way. > please run ./scripts/kernel-doc -none -Wall to find such issues Will fix. Thanks. > > > + */ > > +dma_addr_t virtqueue_dma_map_page_attrs(struct virtqueue *_vq, struct page *page, > > + size_t offset, size_t size, > > + enum dma_data_direction dir, > > + unsigned long attrs)
