On 6/10/2024 6:58 AM, Ira Weiny wrote: > Jeff Johnson wrote: >> Fix the 'make W=1' warnings: >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/libnvdimm.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_pmem.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_btt.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_e820.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/of_pmem.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_virtio.o > > Just to double check. This is a resend of this patch? > > https://lore.kernel.org/all/20240526-md-drivers-nvdimm-v1-1-172e682e76bd@xxxxxxxxxxx/ > > Dave Jiang, I'm picking up all these for the nvdimm tree and I think there > were a couple I was not CC'ed on. I'll coordinate with you because I'm > still seeing a couple of these warnings on other modules in the test > build. > > Also I want to double check all the descriptions before I send for 6.11. > > Jeff is it ok if I alter the text? I know you mentioned to Jonathan you > really just wanted to see the errors go away. Yes, please make the text whatever makes the most sense. In most of these cases I'm not a domain expert so I construct these descriptions based upon code comments, Kconfig descriptions, and git descriptions, and in some cases these are originally wrong due to cut-n-paste or the drivers have evolved so that information is no longer accurate. I need to add a version of that to my b4 cover letter! /jeff
