On Thu, Jun 06, 2024 at 12:25:15PM +0800, Jason Wang wrote: > > If the codes of orphan mode don't have an impact when you enable > > napi_tx mode, please keep it if you can. > > For example, it complicates BQL implementation. > > Thanks I very much doubt sending interrupts to a VM can *on all benchmarks* compete with not sending interrupts. So yea, it's great if napi and hardware are advanced enough that the default can be changed, since this way virtio is closer to a regular nic and more or standard infrastructure can be used. But dropping it will go against *no breaking userspace* rule. Complicated? Tough. -- MST
