On 5/27/24 4:52 오후, Michael S. Tsirkin wrote: > On Mon, May 27, 2024 at 04:13:31PM +0900, yskelg@xxxxxxxxx wrote: >> From: Yunseong Kim <yskelg@xxxxxxxxx> >> >> The virtio_device need to fail checking when create the geust/host pipe. > > typo Thank you for code review Michael. Sorry, there was a typo in my message. I'll fix it and send you patch version 2. >> >> Signed-off-by: Yunseong Kim <yskelg@xxxxxxxxx> > > > I guess ... > >> --- >> tools/virtio/vringh_test.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/tools/virtio/vringh_test.c b/tools/virtio/vringh_test.c >> index 98ff808d6f0c..b1af8807c02a 100644 >> --- a/tools/virtio/vringh_test.c >> +++ b/tools/virtio/vringh_test.c >> @@ -161,8 +161,8 @@ static int parallel_test(u64 features, >> host_map = mmap(NULL, mapsize, PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0); >> guest_map = mmap(NULL, mapsize, PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0); >> >> - pipe(to_guest); >> - pipe(to_host); >> + assert(pipe(to_guest) == 0); >> + assert(pipe(to_host) == 0); > > > I don't like == 0, prefer ! . > Also, calling pipe outside assert is preferable, since in theory > assert can be compiled out. > Not an issue here but people tend to copy/paste text. I agree, it's uncomfortable even if I did it. I'll fix it as you suggested and send it to patch 2. Thank you! Warm Regards, Yunseong Kim >> CPU_ZERO(&cpu_set); >> find_cpus(&first_cpu, &last_cpu); >> -- >> 2.34.1 >
