Bcc: Subject: Re: [PATCH v9 3/8] x86/vmware: Introduce VMware hypercall API Reply-To: In-Reply-To: <683225e0-1cd3-4dea-bb68-086d46b233e8@xxxxxxxxxxxx> + Joe Perches On Wed, May 22, 2024 at 04:39:57PM -0700, Alexey Makhalov wrote: > Hi Simon, apologize for long delay > > On 5/11/24 8:02 AM, Simon Horman wrote: > > > diff --git a/arch/x86/include/asm/vmware.h b/arch/x86/include/asm/vmware.h > > > > ... > > > > > +static inline > > > +unsigned long vmware_hypercall3(unsigned long cmd, unsigned long in1, > > > + uint32_t *out1, uint32_t *out2) > > > > nit: u32 is preferred over uint32_t. > > Likewise elsewhere in this patch-set. > Good to know. Can you please shed a light on the reason? > I still see bunch of stdint style uint32_t in arch/x86. Perhaps there is a document on this that I should know about. But AFAIK, u32 and so on are Linux kernel types, while uint32_t are C99-standard types. Joe, are you able to shed any further light on this? ...
