> From: Jakub Kicinski <kuba@xxxxxxxxxx>
> Sent: Thursday, May 9, 2024 8:31 PM
> To: Dan Jurgens <danielj@xxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; mst@xxxxxxxxxx; jasowang@xxxxxxxxxx;
> xuanzhuo@xxxxxxxxxxxxxxxxx; virtualization@xxxxxxxxxxxxxxx;
> davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; pabeni@xxxxxxxxxx; Jiri
> Pirko <jiri@xxxxxxxxxx>
> Subject: Re: [PATCH net-next 1/2] netdev: Add queue stats for TX stop and
> wake
>
> On Thu, 9 May 2024 11:32:15 -0500 Daniel Jurgens wrote:
> > diff --git a/tools/include/uapi/linux/netdev.h
> > b/tools/include/uapi/linux/netdev.h
> > index cf24f1d9adf8..ccf6976b1693 100644
> > --- a/tools/include/uapi/linux/netdev.h
> > +++ b/tools/include/uapi/linux/netdev.h
> > @@ -164,7 +164,8 @@ enum {
> > NETDEV_A_QSTATS_TX_HW_GSO_BYTES,
> > NETDEV_A_QSTATS_TX_HW_GSO_WIRE_PACKETS,
> > NETDEV_A_QSTATS_TX_HW_GSO_WIRE_BYTES,
> > - NETDEV_A_QSTATS_TX_HW_DROP_RATELIMITS,
>
> Looks like an accidental removal?
Yes, thanks.
>
> > + NETDEV_A_QSTATS_TX_STOP,
> > + NETDEV_A_QSTATS_TX_WAKE,
>
> Since you'll have to respin let me nit pick on the docs, as I'm hoping that
> those will be comprehensible to users not only devs.
>
> > + name: tx-stop
> > + doc: |
> > + Number of times the tx queue was stopped.
>
> How about:
>
> Number of times driver paused accepting new tx packets
> from the stack to this queue, because the queue was full.
> Note that if BQL is supported and enabled on the device
> the networking stack will avoid queuing a lot of data at once.
>
> > + name: tx-wake
> > + doc: |
> > + Number of times the tx queue was restarted.
>
> Number of times driver re-started accepting send
> requests to this queue from the stack.
Will update it. Thanks for the text!
