On Tue, Apr 09, 2024 at 04:37:18PM GMT, Zhu, Lingshan wrote:
On 3/20/2024 12:40 AM, Stefano Garzarella wrote:
On Mon, Feb 19, 2024 at 02:56:05AM +0800, Zhu Lingshan wrote:
This commit report read-only information of
virtio-blk devices to user space.
Signed-off-by: Zhu Lingshan <lingshan.zhu@xxxxxxxxx>
---
drivers/vdpa/vdpa.c | 14 ++++++++++++++
include/uapi/linux/vdpa.h | 1 +
2 files changed, 15 insertions(+)
diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c
index adbcbc7b18b2..d6fd3cadc44f 100644
--- a/drivers/vdpa/vdpa.c
+++ b/drivers/vdpa/vdpa.c
@@ -1084,6 +1084,17 @@
vdpa_dev_blk_write_zeroes_config_fill(struct sk_buff *msg, u64
features,
return 0;
}
+static int vdpa_dev_blk_ro_config_fill(struct sk_buff *msg, u64
features)
+{
+ u8 ro;
+
+ ro = ((features & BIT_ULL(VIRTIO_BLK_F_RO)) == 0) ? 0 : 1;
+ if (nla_put_u8(msg, VDPA_ATTR_DEV_BLK_CFG_READ_ONLY, ro))
This is not really related to the config space, what about renaming it
to VDPA_ATTR_DEV_BLK_READ_ONLY ?
Also the type, maybe better to use "flag" and set it through
`nla_put_flag()`.
Hi Stefano,
I am implementing this change.
In my humble opinion, maybe using a boolean(the u8 above) is better?
If boolean is available, I agree that could be better.
I did just a fast search when I commented.
BTW, sorry for the late reply, I was on PTO.
Stefano
Because using the flag means we conditionally put a "0" into the
attribution,
or the attribution does not exist, this is still a bool logic but
a little vague.
Thanks
Lingshan
Not a strong opinion on that, it just seems a little more consistent to
me.
Thanks,
Stefano
+ return -EMSGSIZE;
+
+ return 0;
+}
+
static int vdpa_dev_blk_config_fill(struct vdpa_device *vdev,
struct sk_buff *msg)
{
@@ -1122,6 +1133,9 @@ static int vdpa_dev_blk_config_fill(struct
vdpa_device *vdev,
if (vdpa_dev_blk_write_zeroes_config_fill(msg,
features_device, &config))
return -EMSGSIZE;
+ if (vdpa_dev_blk_ro_config_fill(msg, features_device))
+ return -EMSGSIZE;
+
return 0;
}
diff --git a/include/uapi/linux/vdpa.h b/include/uapi/linux/vdpa.h
index 797d5708492f..4be8e3a15874 100644
--- a/include/uapi/linux/vdpa.h
+++ b/include/uapi/linux/vdpa.h
@@ -70,6 +70,7 @@ enum vdpa_attr {
VDPA_ATTR_DEV_BLK_CFG_DISCARD_SEC_ALIGN,/* u32 */
VDPA_ATTR_DEV_BLK_CFG_MAX_WRITE_ZEROES_SEC, /* u32 */
VDPA_ATTR_DEV_BLK_CFG_MAX_WRITE_ZEROES_SEG, /* u32 */
+ VDPA_ATTR_DEV_BLK_CFG_READ_ONLY, /* u8 */
/* new attributes must be added above here */
VDPA_ATTR_MAX,
--
2.39.3
