On Thu, 18 Apr 2024 17:48:57 +0200 Paolo Abeni wrote: > > > Side note: the compiler apparently does not like guard() construct, leading to > > > new warning, here and in later patches. I'm unsure if the code simplification > > > is worthy. > > > > I didn't see any warnings with GCC or clang. This is used other places in the kernel as well. > > gcc version 13.2.1 20230918 (Red Hat 13.2.1-3) (GCC) > > clang version 17.0.6 (Fedora 17.0.6-2.fc39) > > > > See: > > https://patchwork.kernel.org/project/netdevbpf/patch/20240416193039.272997-4-danielj@xxxxxxxxxx/ > https://netdev.bots.linux.dev/static/nipa/845178/13632442/build_32bit/stderr > https://netdev.bots.linux.dev/static/nipa/845178/13632442/build_allmodconfig_warn/stderr These are sparse errors, I think, but I agree that there's little gain here and clearly a cost of wasted time, since the standard kernel tooling has not caught with with this ugly invention.
