RE: [PATCH net-next v3 5/6] virtio_net: Add a lock for per queue RX coalesce

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Jakub Kicinski <kuba@xxxxxxxxxx>
> Sent: Tuesday, April 16, 2024 9:27 AM
> To: Dan Jurgens <danielj@xxxxxxxxxx>
> On Tue, 16 Apr 2024 03:15:34 +0000 Dan Jurgens wrote:
> > Which version? It compiles for me with:
> > $ clang -v
> > clang version 15.0.7 (Fedora 15.0.7-2.fc37)
> 
> clang version 17.0.6 (Fedora 17.0.6-2.fc39)
> 

Thanks, I was able to see this with the newer version. The changes to address Heng's comment resolves it as well.

> allmodconfig
> 
> The combination of UNIQUE() goto and guard seems to make it unhappy:
> 
> ../drivers/net/virtio_net.c:3613:3: error: cannot jump from this goto
> statement to its label 3613 |                 goto out; |                 ^
> ../drivers/net/virtio_net.c:3615:2: note: jump bypasses initialization of
> variable with __attribute__((cleanup))
>  3615 |         guard(spinlock)(&rq->intr_coal_lock);
>       |         ^
> ../include/linux/cleanup.h:164:15: note: expanded from macro 'guard'
>   164 |         CLASS(_name, __UNIQUE_ID(guard))
>       |                      ^
> ../include/linux/compiler.h:189:29: note: expanded from macro
> '__UNIQUE_ID'
>   189 | #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_,
> prefix), __COUNTER__)
>       |                             ^
> ./../include/linux/compiler_types.h:84:22: note: expanded from macro
> '__PASTE'
>    84 | #define __PASTE(a,b) ___PASTE(a,b)
>       |                      ^
> ./../include/linux/compiler_types.h:83:23: note: expanded from macro
> '___PASTE'
>    83 | #define ___PASTE(a,b) a##b
>       |                       ^
> <scratch space>:18:1: note: expanded from here
>    18 | __UNIQUE_ID_guard2044
>       | ^
> 1 error generated.





[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux