Sat, Apr 13, 2024 at 03:04:28AM CEST, kuba@xxxxxxxxxx wrote: >On Fri, 12 Apr 2024 17:13:08 +0200 Jiri Pirko wrote: >> This patchset aims at introducing very basic initial infrastructure >> for virtio_net testing, namely it focuses on virtio feature testing. >> >> The first patch adds support for debugfs for virtio devices, allowing >> user to filter features to pretend to be driver that is not capable >> of the filtered feature. > >Two trivial points: MAINTAINERS should probably be updated to bestow >the responsibility over these to virtio folks; there should probably >be a config file. Admittedly anyone testing in a VM should have VIRTIO >and anyone not in a VM won't test this... but it's a good practice. Sure, will add these 2. > >Did you investigate how hard it would be to make virtme-ng pop out >two virtio interfaces? It's a pretty hackable Python code base and >Andrea is very responsive so would be nice to get that done. And then >its trivial to run those in our CI. That is a goal. Currently I do it with: vng --qemu-opts="-nic tap,id=nd0,ifname=xtap0,model=virtio-net-pci,script=no,downscript=no,mac=52:54:00:12:34:57 -nic tap,id=nd1,ifname=xtap1,model=virtio-net-pci,script=no,downscript=no,mac=52:54:00:12:34:58" and setting loop manually with tc-matchall-mirred Implementing virtio loop instantiation in vng is on the todo list for this.
