On Fri, Mar 08, 2024 at 07:46:30PM +0100, Uwe Kleine-König wrote: > Hello Michael, > > On Fri, Mar 08, 2024 at 12:18:26PM -0500, Michael S. Tsirkin wrote: > > On Fri, Mar 08, 2024 at 09:51:20AM +0100, Uwe Kleine-König wrote: > > > The .remove() callback for a platform driver returns an int which makes > > > many driver authors wrongly assume it's possible to do error handling by > > > returning an error code. However the value returned is ignored (apart > > > from emitting a warning) and this typically results in resource leaks. > > > > > > To improve here there is a quest to make the remove callback return > > > void. In the first step of this quest all drivers are converted to > > > .remove_new(), which already returns void. Eventually after all drivers > > > are converted, .remove_new() will be renamed to .remove(). > > > > > > Trivially convert this driver from always returning zero in the remove > > > callback to the void returning variant. > > > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > > > Acked-by: Michael S. Tsirkin <mst@xxxxxxxxxx> > > > > do u want me to merge this? > > I have no merge plan, so if you take it, that would be great. It seems you didn't merge it yet (at least the patch isn't in next). It would be great if this patch made it in during the next merge window as I intend to change struct platform_driver::remove in the merge window leading to 6.11. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
