Re: [PATCH v5 06/22] drivers/perf: riscv: Implement SBI PMU snapshot function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Andrew Jones <ajones@xxxxxxxxxxxxxxxx>
Subject: Re: [PATCH v5 06/22] drivers/perf: riscv: Implement SBI PMU snapshot function
From: Atish Patra <atishp@xxxxxxxxxxxx>
Date: Mon, 8 Apr 2024 17:21:53 -0700
Cc: linux-kernel@xxxxxxxxxxxxxxx, Palmer Dabbelt <palmer@xxxxxxxxxxxx>, Anup Patel <anup@xxxxxxxxxxxxxx>, Conor Dooley <conor.dooley@xxxxxxxxxxxxx>, Ajay Kaher <akaher@xxxxxxxxxx>, Alexandre Ghiti <alexghiti@xxxxxxxxxxxx>, Alexey Makhalov <amakhalov@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, kvm-riscv@xxxxxxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, linux-kselftest@xxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, Mark Rutland <mark.rutland@xxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Paul Walmsley <paul.walmsley@xxxxxxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, virtualization@xxxxxxxxxxxxxxx, VMware PV-Drivers Reviewers <pv-drivers@xxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, x86@xxxxxxxxxx
In-reply-to: <20240404-bbfb02e3aec944f9e11745ae@orel>
References: <20240403080452.1007601-1-atishp@rivosinc.com> <20240403080452.1007601-7-atishp@rivosinc.com> <20240404-bbfb02e3aec944f9e11745ae@orel>
User-agent: Mozilla Thunderbird

On 4/4/24 05:01, Andrew Jones wrote:

On Wed, Apr 03, 2024 at 01:04:35AM -0700, Atish Patra wrote:
...

+static int pmu_sbi_snapshot_disable(void)
+{
+	struct sbiret ret;
+
+	ret = sbi_ecall(SBI_EXT_PMU, SBI_EXT_PMU_SNAPSHOT_SET_SHMEM, -1,
+			-1, 0, 0, 0, 0);


The "Rename the SBI_STA_SHMEM_DISABLE" patch should come before this
patch so SBI_SHMEM_DISABLE can be used instead of the -1's here.


Sure. Done.

Thanks,
drew

References:
- [PATCH v5 00/22] RISC-V SBI v2.0 PMU improvements and Perf sampling in KVM guest
  - From: Atish Patra
- [PATCH v5 06/22] drivers/perf: riscv: Implement SBI PMU snapshot function
  - From: Atish Patra
- Re: [PATCH v5 06/22] drivers/perf: riscv: Implement SBI PMU snapshot function
  - From: Andrew Jones

Prev by Date: Re: [PATCH v5 04/22] drivers/perf: riscv: Use BIT macro for shifting operations
Next by Date: Re: [PATCH v5 12/22] RISC-V: KVM: Implement SBI PMU Snapshot feature
Previous by thread: Re: [PATCH v5 06/22] drivers/perf: riscv: Implement SBI PMU snapshot function
Next by thread: [PATCH v5 07/22] drivers/perf: riscv: Fix counter mask iteration for RV32
Index(es):
- Date
- Thread

[Index of Archives] [KVM Development] [Libvirt Development] [Libvirt Users] [CentOS Virtualization] [Netdev] [Ethernet Bridging] [Linux Wireless] [Kernel Newbies] [Security] [Linux for Hams] [Netfilter] [Bugtraq] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux RAID] [Linux Admin] [Samba]