Re: [PATCH net-next 2/3] vsock/virtio: add SIOCOUTQ support for all virtio based transports

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Stefano,
Thanks for the review.

>We incremented it only for VIRTIO_VSOCK_OP_RW, should we check the
>same here?

Checking for the length of the skbuf or checking for VIRTIO_VSOCK_OP_RW
AFAIK is equivalent. Since the only packet with payload is this one. 
I'll add a comment in v2 to make it more clear.

>What about rename it in `consume`?

Sounds good!

Thanks,
Luigi




[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux