On Fri, Mar 29, 2024 at 12:34:34PM +0000, Srujana Challa wrote: > > > +static void octep_vdpa_set_config(struct vdpa_device *vdpa_dev, unsigned > > int offset, > > > + const void *buf, unsigned int len) > > > +{ > > > + /* Not supported */ > > > > We probably need to filter out VIRTIO_NET_F_ANNOUNCE and other > > features that depend on the config writing. > As per modern virtio spec(v1.2), device config is read only for the driver. > Still do we need to filter out these features? Yes I didn't get this either. What is VIRTIO_NET_F_ANNOUNCE? VIRTIO_NET_F_GUEST_ANNOUNCE? And how does it depend on config writing? -- MST