Re: [PATCH 00/10] vDPA: allow userspace query virito-block device

["Zhu, Lingshan" <lingshan.zhu@xxxxxxxxx>]

On 3/20/2024 12:49 AM, Stefano Garzarella wrote:
> On Mon, Feb 19, 2024 at 02:55:56AM +0800, Zhu Lingshan wrote:
> > This series allows the user space applications query vDPA virtio-block
> > device inforamtion.
> >
> > testing on vdpa_sim_blk, iproute2 output:
> > sudo ./vdpa/vdpa dev config show -jp vdpa_blk0
> > {
> >    "config": {
> >        "vdpa_blk0": {
> >            "capacity": 262144,
> >            "segment size": 4096,
> >            "block size": 512,
> >            "max segments in a request": 32,
> >            "num of queues": 1,
> >            "logical blocks per physical block (log2)": 0,
> >            "offset of first aligned logical block": 0,
> >            "minimum io size": 1,
> >            "optimal io size": 1,
> >            "maximum discard sectors for a segment": 4294967295,
> >            "max discard segments in a command": 1,
> >            "discard sector alignment": 512,
> >            "max write zeros sectors in a segment": 4294967295,
> >            "max write zero segments": 1,
> >            "read only": false,
> >            "flush command support": true
> >        }
> >    }
> > }
> >
> > Please help review
>
> Thanks for this series, and sorry for the deleay.
> I left some comments in the patch, about the virtio-blk config space
> there are some missing fields:
> - virtio_blk_geometry fields
> - writeback field
> - *secure_erase* fields
> - virtio_blk_zoned_characteristics fields
>
> Do you plan to add them later?
Yes, I will work on them and will send another series which
also addressing your comments for this series

Thanks
Zhu Lingshan
> Thanks,
> Stefano