Re: [PATCH vhost 3/4] virtio: vring_new_virtqueue(): pass struct instead of multi parameters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH vhost 3/4] virtio: vring_new_virtqueue(): pass struct instead of multi parameters
From: Xuan Zhuo <xuanzhuo@xxxxxxxxxxxxxxxxx>
Date: Tue, 5 Mar 2024 19:36:35 +0800
Cc: virtualization@xxxxxxxxxxxxxxx, Richard Weinberger <richard@xxxxxx>, Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, Hans de Goede <hdegoede@xxxxxxxxxx>, Vadim Pasternak <vadimp@xxxxxxxxxx>, Bjorn Andersson <andersson@xxxxxxxxxx>, Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>, Cornelia Huck <cohuck@xxxxxxxxxx>, Halil Pasic <pasic@xxxxxxxxxxxxx>, Eric Farman <farman@xxxxxxxxxxxxx>, Heiko Carstens <hca@xxxxxxxxxxxxx>, Vasily Gorbik <gor@xxxxxxxxxxxxx>, Alexander Gordeev <agordeev@xxxxxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>, Sven Schnelle <svens@xxxxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, linux-um@xxxxxxxxxxxxxxxxxxx, platform-driver-x86@xxxxxxxxxxxxxxx, linux-remoteproc@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx
In-reply-to: <0cbf4910-ec0c-4b06-681e-aafae3720455@linux.intel.com>
References: <20240304114719.3710-1-xuanzhuo@linux.alibaba.com> <20240304114719.3710-4-xuanzhuo@linux.alibaba.com> <0cbf4910-ec0c-4b06-681e-aafae3720455@linux.intel.com>

On Tue, 5 Mar 2024 13:27:25 +0200 (EET), =?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@xxxxxxxxxxxxxxx> wrote:
> On Mon, 4 Mar 2024, Xuan Zhuo wrote:
>
> > Just like find_vqs(), it is time to refactor the
> > vring_new_virtqueue(). We pass the similar struct to
> > vring_new_virtqueue.
>
> Please write a proper commit message here and do not just refer to
> some other commit to describe what's going on here.


YES.

Thanks.


>
> --
>  i.
>

References:
- [PATCH vhost 0/4] refactor the params of find_vqs()
  - From: Xuan Zhuo
- [PATCH vhost 3/4] virtio: vring_new_virtqueue(): pass struct instead of multi parameters
  - From: Xuan Zhuo
- Re: [PATCH vhost 3/4] virtio: vring_new_virtqueue(): pass struct instead of multi parameters
  - From: Ilpo Järvinen

Prev by Date: Re: [PATCH vhost 1/4] virtio: find_vqs: pass struct instead of multi parameters
Next by Date: Re: [PATCH v6 7/7] Documentation: KVM: Add hypercall for LoongArch
Previous by thread: Re: [PATCH vhost 3/4] virtio: vring_new_virtqueue(): pass struct instead of multi parameters
Next by thread: [PATCH vhost 4/4] virtio_ring: simplify the parameters of the funcs related to vring_create/new_virtqueue()
Index(es):
- Date
- Thread

[Index of Archives] [KVM Development] [Libvirt Development] [Libvirt Users] [CentOS Virtualization] [Netdev] [Ethernet Bridging] [Linux Wireless] [Kernel Newbies] [Security] [Linux for Hams] [Netfilter] [Bugtraq] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux RAID] [Linux Admin] [Samba]