Re: [PATCH 03/15] block: decouple blk_set_stacking_limits from blk_set_default_limits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 12, 2024 at 04:14:48PM +0900, Damien Le Moal wrote:
> > -	blk_set_default_limits(lim);
> > +	memset(lim, 0, sizeof(*lim));
> > +	lim->logical_block_size = lim->physical_block_size = lim->io_min = 512;
> > +	lim->discard_granularity = 512;
> 
> Super minor nit: SECTOR_SIZE would be nice here.

Just a code movement / copy, but otherwise yes.  This code should go
away when updating the stacking to the new API, so I'm not going to
bother.





[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux