On Wed, Jan 31, 2024 at 05:36:18PM -0700, Keith Busch wrote: > > + q->limits.max_user_discard_sectors = max_discard_bytes >> SECTOR_SHIFT; > > + q->limits.max_discard_sectors = > > + min_not_zero(q->limits.max_hw_discard_sectors, > > + q->limits.max_user_discard_sectors); > > s/min_not_zero/min Yes. Fixed up right after when converting to the limits based update, but this does create a bisection hazard as-is.