On 1/26/24 00:41, Dmitry Osipenko wrote: > On 1/5/24 21:46, Dmitry Osipenko wrote: >> for (i = page_offset; i < page_offset + NUM_FAULT_PAGES; i++) { >> + /* Can happen if the last fault only partially filled this >> + * section of the pages array before failing. In that case >> + * we skip already filled pages. >> + */ >> + if (pages[i]) >> + continue; >> + >> pages[i] = shmem_read_mapping_page(mapping, i); > > Although, the shmem_read_mapping_page() should return same page if it > was already allocated, isn't it? I.e. there was no bug here and the > fixes/stable tags not needed. Scratch that, I forgot that the patch is about the unbalanced get/put_pages -- Best regards, Dmitry