Re: [PATCH next v2 1/5] locking/osq_lock: Defer clearing node->locked until the slow osq_lock() path.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 12/31/23 16:51, David Laight wrote:
Since node->locked cannot be set before the assignment to prev->next
it is save to clear it in the slow path.

Signed-off-by: David Laight <david.laight@xxxxxxxxxx>
---
  kernel/locking/osq_lock.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/locking/osq_lock.c b/kernel/locking/osq_lock.c
index 75a6f6133866..e0bc74d85a76 100644
--- a/kernel/locking/osq_lock.c
+++ b/kernel/locking/osq_lock.c
@@ -97,7 +97,6 @@ bool osq_lock(struct optimistic_spin_queue *lock)
  	int curr = encode_cpu(smp_processor_id());
  	int old;
- node->locked = 0;
  	node->next = NULL;
  	node->cpu = curr;
@@ -111,6 +110,7 @@ bool osq_lock(struct optimistic_spin_queue *lock)
  	if (old == OSQ_UNLOCKED_VAL)
  		return true;
+ node->locked = 0;
  	prev = decode_cpu(old);
  	node->prev = prev;

Reviewed-by: Waiman Long <longman@xxxxxxxxxx>





[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux