On Tue, Dec 5, 2023 at 4:02 PM Heng Qi <hengqi@xxxxxxxxxxxxxxxxx> wrote: > > Currently access to ctrl cmd is globally protected via rtnl_lock and works > fine. But if dim work's access to ctrl cmd also holds rtnl_lock, deadlock > may occur due to cancel_work_sync for dim work. Can you explain why? > Therefore, treating > ctrl cmd as a separate protection object of the lock is the solution and > the basis for the next patch. Let's don't do that. Reasons are: 1) virtnet_send_command() may wait for cvq commands for an indefinite time 2) hold locks may complicate the future hardening works around cvq Thanks
