Re: [PATCH net-next v3 5/5] virtio-net: return -EOPNOTSUPP for adaptive-tx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Heng Qi <hengqi@xxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH net-next v3 5/5] virtio-net: return -EOPNOTSUPP for adaptive-tx
From: Jakub Kicinski <kuba@xxxxxxxxxx>
Date: Tue, 14 Nov 2023 23:23:05 -0500
Cc: netdev@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, Jason Wang <jasowang@xxxxxxxxxx>, "Michael S . Tsirkin" <mst@xxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, "David S . Miller" <davem@xxxxxxxxxxxxx>, Jesper Dangaard Brouer <hawk@xxxxxxxxxx>, John Fastabend <john.fastabend@xxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxx>, xuanzhuo@xxxxxxxxxxxxxxxxx
In-reply-to: <6a79229fbeb72edf41185a45a0f9ea5cd87a1086.1699938946.git.hengqi@linux.alibaba.com>
References: <cover.1699938946.git.hengqi@linux.alibaba.com> <6a79229fbeb72edf41185a45a0f9ea5cd87a1086.1699938946.git.hengqi@linux.alibaba.com>

On Tue, 14 Nov 2023 13:55:47 +0800 Heng Qi wrote:
> We do not currently support tx dim, so respond to -EOPNOTSUPP.

Hm, why do you need this? You don't set ADAPTIVE_TX in
.supported_coalesce_params, so core should prevent attempts
to enable ADAPTIVE_TX.

Follow-Ups:
- Re: [PATCH net-next v3 5/5] virtio-net: return -EOPNOTSUPP for adaptive-tx
  - From: Heng Qi

References:
- [PATCH net-next v3 0/5] virtio-net: support dynamic coalescing moderation
  - From: Heng Qi
- [PATCH net-next v3 5/5] virtio-net: return -EOPNOTSUPP for adaptive-tx
  - From: Heng Qi

Prev by Date: [PATCH AUTOSEL 5.15 2/4] drm/qxl: prevent memory leak
Next by Date: Re: [PATCH net-next v3 5/5] virtio-net: return -EOPNOTSUPP for adaptive-tx
Previous by thread: [PATCH net-next v3 5/5] virtio-net: return -EOPNOTSUPP for adaptive-tx
Next by thread: Re: [PATCH net-next v3 5/5] virtio-net: return -EOPNOTSUPP for adaptive-tx
Index(es):
- Date
- Thread

[Index of Archives] [KVM Development] [Libvirt Development] [Libvirt Users] [CentOS Virtualization] [Netdev] [Ethernet Bridging] [Linux Wireless] [Kernel Newbies] [Security] [Linux for Hams] [Netfilter] [Bugtraq] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux RAID] [Linux Admin] [Samba]