On Sat, Nov 11, 2023 at 6:18 AM Shannon Nelson <shannon.nelson@xxxxxxx> wrote:
>
> If the client driver is setting status to 0, something is
> getting shutdown and possibly removed. Make sure we clear
> the config_cb so that it doesn't end up crashing when
> trying to call a bogus callback.
>
> Signed-off-by: Shannon Nelson <shannon.nelson@xxxxxxx>
Acked-by: Jason Wang <jasowang@xxxxxxxxxx>
Thanks
> ---
> drivers/vdpa/pds/vdpa_dev.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/pds/vdpa_dev.c b/drivers/vdpa/pds/vdpa_dev.c
> index 52b2449182ad..9fc89c82d1f0 100644
> --- a/drivers/vdpa/pds/vdpa_dev.c
> +++ b/drivers/vdpa/pds/vdpa_dev.c
> @@ -461,8 +461,10 @@ static void pds_vdpa_set_status(struct vdpa_device *vdpa_dev, u8 status)
>
> pds_vdpa_cmd_set_status(pdsv, status);
>
> - /* Note: still working with FW on the need for this reset cmd */
> if (status == 0) {
> + struct vdpa_callback null_cb = { };
> +
> + pds_vdpa_set_config_cb(vdpa_dev, &null_cb);
> pds_vdpa_cmd_reset(pdsv);
>
> for (i = 0; i < pdsv->num_vqs; i++) {
> --
> 2.17.1
>
