Hi Michael & Lei,
I volunteer to fix this by workqueue.
I also notice that device drivers use workqueue to handle config-changed
again and again, what about re-implement __virtio_config_changed() by
kicking workqueue instead?
By the way, balloon dirvers uses
spin_lock_irqsave/spin_unlock_irqrestore in config-changed callback, do
it handle correctly?
On 9/27/23 21:25, Halil Pasic wrote:
On Wed, 27 Sep 2023 09:24:09 +0000
"Gonglei (Arei)" <arei.gonglei@xxxxxxxxxx> wrote:
On a related note, config change callback is also handled incorrectly in this
driver, it takes a mutex from interrupt context.
Good catch. Will fix it.
Thanks Gonglei! Sorry I first misunderstood this as a problem within the
virtio-ccw driver, but it is actually about virtio-crypto. Thanks for
fixing this!
Regards,
Halil
--
zhenwei pi
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
