Weird locking hierarchy in virtcrypto

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



While backporting an upstream patch to one of our older distro kernels I've
found a weird locking hierarchy in the virtio crypto driver:

virtio_config_changed():
  spin_lock_irqsave()
  ->__virtio_config_changed()
      ->drv->config_changed()      <- assume drv == virtio_crypto_driver
        virtcrypto_config_changed():
          ->virtcrypto_update_status()
              ->virtcrypto_dev_start()
                  ->virtio_crypto_skcipher_algs_register()
                      mutex_lock()

I don't think trying to take a mutex while holding a spinlock with interrupts
disabled is a proper thing to do.

Am I overlooking something here?


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux