On Tue, Sep 12, 2023 at 2:08 AM Shannon Nelson <shannon.nelson@xxxxxxx> wrote:
>
> From: Allen Hubbe <allen.hubbe@xxxxxxx>
>
> Consume the parameter to device_features when parsing command line
> options. Otherwise the parameter may be used again as an option name.
>
> # vdpa dev add ... device_features 0xdeadbeef mac 00:11:22:33:44:55
> Unknown option "0xdeadbeef"
>
> Fixes: a4442ce58ebb ("vdpa: allow provisioning device features")
> Signed-off-by: Allen Hubbe <allen.hubbe@xxxxxxx>
> Reviewed-by: Shannon Nelson <shannon.nelson@xxxxxxx>
> Reviewed-by: Si-Wei Liu <si-wei.liu@xxxxxxxxxx>
Acked-by: Jason Wang <jasowang@xxxxxxxxxx>
Thanks
> ---
> vdpa/vdpa.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/vdpa/vdpa.c b/vdpa/vdpa.c
> index 8bbe452c..6e4a9c11 100644
> --- a/vdpa/vdpa.c
> +++ b/vdpa/vdpa.c
> @@ -353,6 +353,8 @@ static int vdpa_argv_parse(struct vdpa *vdpa, int argc, char **argv,
> &opts->device_features);
> if (err)
> return err;
> +
> + NEXT_ARG_FWD();
> o_found |= VDPA_OPT_VDEV_FEATURES;
> } else {
> fprintf(stderr, "Unknown option \"%s\"\n", *argv);
> --
> 2.17.1
>
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
