Re: [PATCH v6 0/3] Add sync object UAPI support to VirtIO-GPU driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Wed, Jul 19, 2023 at 11:58 AM Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx> wrote:
27.06.2023 20:16, Rob Clark пишет:
>> Now these are just suggestions, and while I think they are good, you can safely ignore them.
>> But there's also the DRM requirements, which state "userspace side must be fully reviewed and tested to the standards of that user-space project.".  So I think to meet the minimum requirements, I think we should at-least have one of the following (not all, just one) reviewed:
>> 1) venus using the new uapi
>> 2) gfxstream vk using the new uapi
>> 3) amdgpu nctx out of "draft" mode and using the new uapi.
>> 4) virtio-intel using new uapi
>> 5) turnip using your new uapi
> forgot to mention this earlier, but
> Dmitry, you can also add, if you haven't already:
> Tested-by: Rob Clark <robdclark@xxxxxxxxx>

Gurchetan, Turnip Mesa virtio support is ready to be merged upstream,
it's using this new syncobj UAPI. Could you please give yours r-b if you
don't have objections?

Given that Turnip native contexts are reviewed using this UAPI, your change does now meet the requirements and is ready to merge.  

One thing I noticed is you might need explicit padding between `num_out_syncobjs` and `in_syncobjs`.  Otherwise, feel free to add my acked-by.

Best regards,

Virtualization mailing list

[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux