On Thu, Jul 13, 2023 at 03:55:45PM +1000, Vadim Rozenfeld wrote: > Currently we use 4-byte alignmed (FILE_LONG_ALIGNMENT) in both Windows > virtio blk and scsi miniport drivers. > It shouldn't be a problem to change it to 512 by setting AlignmentMask > field of PORT_CONFIGURATION_INFORMATION structure > ( > https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/storport/ns-storport-_port_configuration_information > ) > to FILE_512_BYTE_ALIGNMENT. > I don't see any problem with changing the alignment parameter in our > drivers. But it will take us some time to test it properly. Hi Vadim, After looking at this again, I confused memory address/size alignment with request offset/length alignment. The virtio-scsi device does not have memory alignment constraints, so FILE_LONG_ALIGNMENT is okay and there's no need to change it. Thanks, Stefan
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
