On Mon, Jun 05, 2023 at 06:48:43AM -0700, 赵盛 wrote:
> Fixes: c8a6153b6c59 ("vduse: Introduce VDUSE - vDPA Device in Userspace")
Thanks! Just don't do the mangled text and avoid top-posting in the
future.
> From: "Michael S. Tsirkin"<mst@xxxxxxxxxx>
> Date: Mon, Jun 5, 2023, 21:24
> Subject: [External] Re: [PATCH] vduse: avoid empty string for dev name
> To: "赵盛"<sheng.zhao@xxxxxxxxxxxxx>
> Cc: "Yongji Xie"<xieyongji@xxxxxxxxxxxxx>, "Jason Wang"<jasowang@xxxxxxxxxx>,
> "virtualization"<virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx>, "Xianjun Zeng"<
> zengxianjun@xxxxxxxxxxxxx>
> On Mon, Jun 05, 2023 at 06:17:55AM -0700, 赵盛 wrote: > Hi Yongji, > Thanks
> for your feedback, I'll resubmit the patch with this change. Just send a Fixes
> tag in a reply no need to resubmit - I queued it already. > Sheng > From:
> "Yongji Xie"<xieyongji@xxxxxxxxxxxxx> > Date: Thu, Jun 1, 2023, 11:31 >
> Subject: Re: [PATCH] vduse: avoid empty string for dev name > To: "Sheng Zhao"
> <sheng.zhao@xxxxxxxxxxxxx> > Cc: "Michael S. Tsirkin"<mst@xxxxxxxxxx>, "Jason
> Wang"<jasowang@xxxxxxxxxx>, > "virtualization"<
> virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx>, "Xianjun Zeng"< >
> zengxianjun@xxxxxxxxxxxxx> > On Tue, May 30, 2023 at 11:37 AM Sheng Zhao <
> sheng.zhao@xxxxxxxxxxxxx> wrote: > > > > Syzkaller hits a kernel WARN when the
> first character of the dev name > > provided is NULL. Solution is to add a NULL
> check before calling > > cdev_device_add() in vduse_create_dev(). > > > >
> kobject: (0000000072042169): attempted to be registered with empty name! > >
> WARNING: CPU: 0 PID: 112695 at lib/kobject.c:236 > > Call Trace: > >
> kobject_add_varg linux/src/lib/kobject.c:390 [inline] > > kobject_add+0xf6/
> 0x150 linux/src/lib/kobject.c:442 > > device_add+0x28f/0xc20 linux/src/drivers
> /base/core.c:2167 > > cdev_device_add+0x83/0xc0 linux/src/fs/char_dev.c:546 >
> > vduse_create_dev linux/src/drivers/vdpa/vdpa_user/vduse_dev.c:2254 [inline]
> > > vduse_ioctl+0x7b5/0xf30 linux/src/drivers/vdpa/vdpa_user/vduse_dev.c:2316
> > > vfs_ioctl linux/src/fs/ioctl.c:47 [inline] > > file_ioctl linux/src/fs/
> ioctl.c:510 [inline] > > do_vfs_ioctl+0x14b/0xa80 linux/src/fs/ioctl.c:697 > >
> ksys_ioctl+0x7c/0xa0 linux/src/fs/ioctl.c:714 > > __do_sys_ioctl linux/src/
> fs/ioctl.c:721 [inline] > > __se_sys_ioctl linux/src/fs/ioctl.c:719 [inline] >
> > __x64_sys_ioctl+0x42/0x50 linux/src/fs/ioctl.c:719 > > do_syscall_64+0x94/
> 0x330 linux/src/arch/x86/entry/common.c:291 > >
> entry_SYSCALL_64_after_hwframe+0x44/0xa9 > > > > Reported-by: Xianjun Zeng <
> zengxianjun@xxxxxxxxxxxxx> > > Signed-off-by: Sheng Zhao <
> sheng.zhao@xxxxxxxxxxxxx> > > Miss a "Fixes" tag. Others look good to me. > >
> Reviewed-by: Xie Yongji <xieyongji@xxxxxxxxxxxxx> > > Thanks, > Yongji >
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
