Re: [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
Subject: Re: [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression
From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Sat, 27 May 2023 18:21:03 -0700
Cc: axboe@xxxxxxxxx, brauner@xxxxxxxxxx, mst@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Oleg Nesterov <oleg@xxxxxxxxxx>, stefanha@xxxxxxxxxx, linux@xxxxxxxxxxxxx, nicolas.dichtel@xxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
In-reply-to: <87mt1pmezu.fsf@email.froward.int.ebiederm.org>
References: <20230522025124.5863-1-michael.christie@oracle.com> <20230522025124.5863-4-michael.christie@oracle.com> <20230522123029.GA22159@redhat.com> <cfca7764-d210-6df9-e182-2c093101c6cf@oracle.com> <20230522174757.GC22159@redhat.com> <20230523121506.GA6562@redhat.com> <87bkib6nxr.fsf@email.froward.int.ebiederm.org> <20230524141022.GA19091@redhat.com> <87ttw1zt4i.fsf@email.froward.int.ebiederm.org> <20230525115512.GA9229@redhat.com> <87y1lcxwcj.fsf@email.froward.int.ebiederm.org> <CAHk-=wj4DS=2F5mW+K2P7cVqrsuGd3rKE_2k2BqnnPeeYhUCvg@mail.gmail.com> <87cz2mrtnk.fsf@email.froward.int.ebiederm.org> <CAHk-=whsi9JFP-okH3jXHrA8rh8bMuuSt6ZgkmPwiDMAn437qA@mail.gmail.com> <87mt1pmezu.fsf@email.froward.int.ebiederm.org>

On Sat, May 27, 2023 at 6:17 PM Eric W. Biederman <ebiederm@xxxxxxxxxxxx> wrote:
>
> It seems like a good approach for including in the -rc series.
> I think the change should look more like my change below.

I have no objections. My patch was a fairly "hack and slash" thing to
just disassociate the IO workers entirely from the core dumping. Yours
seems to be slightly more surgical.

                  Linus
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

References:
- [PATCH 0/3] vhost: Fix freezer/ps regressions
  - From: Mike Christie
- [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression
  - From: Mike Christie
- Re: [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression
  - From: Oleg Nesterov
- Re: [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression
  - From: Mike Christie
- Re: [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression
  - From: Oleg Nesterov
- Re: [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression
  - From: Oleg Nesterov
- Re: [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression
  - From: Eric W. Biederman
- Re: [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression
  - From: Oleg Nesterov
- Re: [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression
  - From: Eric W. Biederman
- Re: [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression
  - From: Oleg Nesterov
- Re: [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression
  - From: Eric W. Biederman
- Re: [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression
  - From: Linus Torvalds
- Re: [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression
  - From: Eric W. Biederman
- Re: [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression
  - From: Linus Torvalds
- Re: [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression
  - From: Eric W. Biederman

Prev by Date: Re: [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression
Next by Date: Re: [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression
Previous by thread: Re: [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression
Next by thread: Re: [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression
Index(es):
- Date
- Thread

[Index of Archives] [KVM Development] [Libvirt Development] [Libvirt Users] [CentOS Virtualization] [Netdev] [Ethernet Bridging] [Linux Wireless] [Kernel Newbies] [Security] [Linux for Hams] [Netfilter] [Bugtraq] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux RAID] [Linux Admin] [Samba]