On Tue, 23 May 2023 03:19:42 -0400, "Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote: > On Mon, May 22, 2023 at 11:03:26PM -0700, Christoph Hellwig wrote: > > On Wed, May 17, 2023 at 10:22:41AM +0800, Xuan Zhuo wrote: > > > virtuque_add() adds parameter premapped. > > > > Well, I can see that. But why? > > Assuming it's intentional, it should say something along the lines of > "The parameter is unused for now, and all callers just pass false. > It will be used by a follow-up patch". I agree. Will fix. > > It's not a bad way to split patches, this way actual logic in > the next patch stands out as opposed to being masked by > the code reshuffling following the extra parameter. I think so. Thanks. > > -- > MST > _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
