On Fri, 12 May 2023 08:05:35 -0700, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > As said before, please don't try to do weird runtime checks based > on the scatterlist. What you have works for now, but there are > plans to repalce the page + offset tuple in the scatterlist with > just a phys_addr_t. And with that your "clever" scheme will break > instantly. Sorry, I missed this email for some reason. Thanks for Jason's reply. Although, I think that the interface sg_page() should not have any problems. If we use phys_addr_t replace the page + offset, this interface sg_page() should be update or replace. But i will follow your advice. I have another question. I done some modification on scatterlist (inside virtqueue_map_sgs()) in the patch using dma_address to save the dma address got by virtio core. I want to know if this behavior is suitable. Thanks. > _______________________________________________ > Virtualization mailing list > Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx > https://lists.linuxfoundation.org/mailman/listinfo/virtualization > _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
