Re: [PATCH vhost v7 01/11] virtio_ring: split: separate dma codes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 30 Apr 2023 21:24:52 -0700, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> > +static dma_addr_t vring_sg_address(struct scatterlist *sg)
> > +{
> > +	if (sg->dma_address)
> > +		return sg->dma_address;
>
> 0 is a perfectly valid DMA address.  So I have no idea how this is
> even supposed to work.


Yes.

I think I can change it here to judge based on sg_page(sg). If there is no page,
I assume this sg already has DMA Address.

Thanks


_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization



[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux