On Tue, 21 Mar 2023 23:34:43 -0400, "Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote: > On Wed, Mar 22, 2023 at 11:03:00AM +0800, Xuan Zhuo wrote: > > Due to historical reasons, the implementation of XDP in virtio-net is relatively > > chaotic. For example, the processing of XDP actions has two copies of similar > > code. Such as page, xdp_page processing, etc. > > > > The purpose of this patch set is to refactor these code. Reduce the difficulty > > of subsequent maintenance. Subsequent developers will not introduce new bugs > > because of some complex logical relationships. > > > > In addition, the supporting to AF_XDP that I want to submit later will also need > > to reuse the logic of XDP, such as the processing of actions, I don't want to > > introduce a new similar code. In this way, I can reuse these codes in the > > future. > > > > Please review. > > > > Thanks. > > I really want to see that code make progress though. I want to know, you refer to virtio-net + AF_XDP or refactor for XDP. > Would it make sense to merge this one through the virtio tree? There are some small problems that we merge this patch-set to Virtio Tree directly. Thanks. > > Then you will have all the pieces in one place and try to target > next linux. > > > > Xuan Zhuo (8): > > virtio_net: mergeable xdp: put old page immediately > > virtio_net: mergeable xdp: introduce mergeable_xdp_prepare > > virtio_net: introduce virtnet_xdp_handler() to seprate the logic of > > run xdp > > virtio_net: separate the logic of freeing xdp shinfo > > virtio_net: separate the logic of freeing the rest mergeable buf > > virtio_net: auto release xdp shinfo > > virtio_net: introduce receive_mergeable_xdp() > > virtio_net: introduce receive_small_xdp() > > > > drivers/net/virtio_net.c | 615 +++++++++++++++++++++++---------------- > > 1 file changed, 357 insertions(+), 258 deletions(-) > > > > -- > > 2.32.0.3.g01195cf9f > _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
