On Thu, Mar 09, 2023 at 10:24:19AM +0100, Jiri Pirko wrote: > >Nice but the bigger problem is not the mistake - it is the posting of > >untested code. It might be an ok thing to do - as long as you make it > >super abundantrly clear that this is what it is, and explain why > >you are posting it now and not after testing. > > Isn't there some ci running with posted patches here? That would uncover > it right away. In netdev world, this is very convenient. Example: > https://patchwork.kernel.org/project/netdevbpf/list/?series=727865 > Patch won't apply. It is a best effort thing and is not an excuse to post untested patches for review. If I see a patch I expect that the author made sure the patch does what it's supposed to do. -- MST _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
