On Tue, Mar 07, 2023 at 10:53:41AM +0100, Paolo Abeni wrote: > Hi, > On Tue, 2023-03-07 at 09:49 +0800, Xuan Zhuo wrote: > > On Mon, 6 Mar 2023 12:58:22 -0500, "Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote: > > > On Mon, Mar 06, 2023 at 12:15:33PM +0800, Xuan Zhuo wrote: > > > > If the queue of xdp xmit is not an independent queue, then when the xdp > > > > xmit used all the desc, the xmit from the __dev_queue_xmit() may encounter > > > > the following error. > > > > > > > > net ens4: Unexpected TXQ (0) queue failure: -28 > > > > > > > > This patch adds a check whether sq is full in XDP Xmit. > > > > > > > > Thanks. > > > > > > Acked-by: Michael S. Tsirkin <mst@xxxxxxxxxx> > > > > > > needed for stable? > > > > Yes i think. > > Could you please re-post including a suitable 'Fixes' tag? That would > address stable, too. Additionally you could rename check_sq_full() in > patch 1, perhaps 'check_disable_sq_full()' would do. Not that's even more confusing it sounds like it's checking that it's checking that sq is disabled unless one looks closely. I think check_sq_full_and_disable() is better. > You can retain the already collected tags. > > Thanks! > > Paolo _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
