On Fri, Mar 03, 2023 at 04:46:03PM -0800, Jakub Kicinski wrote:
> On Thu, 2 Mar 2023 04:48:38 -0500 Michael S. Tsirkin wrote:
> > > Looks not the core can try to enable and disable features according to
> > > the diff between features and hw_features
> > >
> > > static inline netdev_features_t netdev_get_wanted_features(
> > > struct net_device *dev)
> > > {
> > > return (dev->features & ~dev->hw_features) | dev->wanted_features;
> > > }
> >
> > yes what we do work according to code. So the documentation is wrong then?
>
> It's definitely incomplete but which part are you saying is wrong?
So it says:
2. netdev->features set contains features which are currently enabled
for a device.
ok so far.
But this part:
This should be changed only by network core or in
error paths of ndo_set_features callback.
seems to say virtio should not touch netdev->features, no?
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
