Re: [PATCH -next] vdpa/mlx5: fix check wrong pointer in mlx5_vdpa_add_mac_vlan_rules()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Were you going to do this?

On Wed, Jan 04, 2023 at 02:31:52PM +0000, Eli Cohen wrote:
> Sure, thanks!
> 
> > -----Original Message-----
> > From: Michael S. Tsirkin <mst@xxxxxxxxxx>
> > Sent: Wednesday, 4 January 2023 15:58
> > To: Eli Cohen <elic@xxxxxxxxxx>
> > Cc: Yang Yingliang <yangyingliang@xxxxxxxxxx>; virtualization@lists.linux-
> > foundation.org; jasowang@xxxxxxxxxx
> > Subject: Re: [PATCH -next] vdpa/mlx5: fix check wrong pointer in
> > mlx5_vdpa_add_mac_vlan_rules()
> > 
> > On Wed, Jan 04, 2023 at 11:41:31AM +0000, Eli Cohen wrote:
> > > I see these patches were not sent yet.
> > > Michael/Yang Yinglliang, isn't it better to send a fixed patch instead of
> > sending the original and fix on top of it?
> > 
> > depends on the severity of the fix. in this case it seems to leak
> > uninitialized stack data to userspace, so I'd say it's best to
> > squash in the fix.
> > keep signed-off by of the fixup contributor so they get attribution.
> > 
> > --
> > MST
> 

_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization



[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux