On Fri, Dec 30, 2022 at 10:51 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > > On Tue, 27 Dec 2022 17:06:10 +0800 Jason Wang wrote: > > > Hmm so user tells us to e.g enable promisc. We report completion > > > but card is still dropping packets. I think this > > > has a chance to break some setups. > > > > I think all those filters are best efforts, am I wrong? > > Are the flags protected by the addr lock which needs BH, tho? > > Taking netif_addr_lock_bh() to look at dev->flags seems a bit > surprising to me. > Yes, RTNL should be sufficient here. Will fix it. Thanks _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
