Hi Bjorn, > Hi Alvaro, > > On Mon, Dec 19, 2022 at 10:35:09AM +0200, Alvaro Karsz wrote: > > The vendor id is used in 2 differrent source files, > > the SNET vdpa driver and pci quirks. > > s/id/ID/ # both in subject and commit log > s/differrent/different/ > s/vdpa/vDPA/ # seems to be the conventional style > s/pci/PCI/ > > Make the commit log say what this patch does. > > > Signed-off-by: Alvaro Karsz <alvaro.karsz@xxxxxxxxxxxxx> > > With the above and the sorting fix below: > > Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > > > --- > > include/linux/pci_ids.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > > index b362d90eb9b..33bbe3160b4 100644 > > --- a/include/linux/pci_ids.h > > +++ b/include/linux/pci_ids.h > > @@ -3115,4 +3115,6 @@ > > > > #define PCI_VENDOR_ID_NCUBE 0x10ff > > > > +#define PCI_VENDOR_ID_SOLIDRUN 0xd063 > > Move this to the right spot so the file is sorted by vendor ID. > PCI_VENDOR_ID_NCUBE, PCI_VENDOR_ID_OCZ, and PCI_VENDOR_ID_XEN got > added in the wrong place. > > > #endif /* _LINUX_PCI_IDS_H */ > > -- Thanks for your comments. The patch was taken by another maintainer (CCed) https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git/commit/?h=linux-next&id=afc9dcfb846bf35aa7afb160d5370ab5c75e7a70 So, Michael and Bjorn, Do you want me to create a new version, or fix it in a follow up patch? BTW, the same is true for the next patch in the series, New PCI quirk for SolidRun SNET DPU https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git/commit/?h=linux-next&id=136dd8d8f3a0ac19f75a875e9b27b83d365a5be3 Thanks. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
