On Wed, Oct 12, 2022 at 5:01 AM Max Gurtovoy <mgurtovoy@xxxxxxxxxx> wrote: > > > On 10/12/2022 11:42 AM, Max Gurtovoy wrote: > > > > On 10/12/2022 8:02 AM, Michael S. Tsirkin wrote: > >> On Thu, Sep 29, 2022 at 02:40:08AM +0300, Max Gurtovoy wrote: > >>> This is instead of re-writing the same logic in virtio driver. > >>> > >>> Signed-off-by: Max Gurtovoy <mgurtovoy@xxxxxxxxxx> > >> Dropped this as it caused build failures: > >> > >> https://lore.kernel.org/r/202210080424.gSmuYfb0-lkp%40intel.com > > > > maybe you can re-run it with: > > > > diff --git a/drivers/virtio/Makefile b/drivers/virtio/Makefile > > index 8e98d24917cc..b383326a20e2 100644 > > --- a/drivers/virtio/Makefile > > +++ b/drivers/virtio/Makefile > > @@ -5,10 +5,11 @@ obj-$(CONFIG_VIRTIO_PCI_LIB) += virtio_pci_modern_dev.o > > obj-$(CONFIG_VIRTIO_PCI_LIB_LEGACY) += virtio_pci_legacy_dev.o > > obj-$(CONFIG_VIRTIO_MMIO) += virtio_mmio.o > > obj-$(CONFIG_VIRTIO_PCI) += virtio_pci.o > > -virtio_pci-y := virtio_pci_modern.o virtio_pci_common.o > > -virtio_pci-$(CONFIG_VIRTIO_PCI_LEGACY) += virtio_pci_legacy.o > > obj-$(CONFIG_VIRTIO_BALLOON) += virtio_balloon.o > > obj-$(CONFIG_VIRTIO_INPUT) += virtio_input.o > > obj-$(CONFIG_VIRTIO_VDPA) += virtio_vdpa.o > > obj-$(CONFIG_VIRTIO_MEM) += virtio_mem.o > > obj-$(CONFIG_VIRTIO_DMA_SHARED_BUFFER) += virtio_dma_buf.o > > + > > +virtio_pci-$(CONFIG_VIRTIO_PCI) := virtio_pci_modern.o > > virtio_pci_common.o > > +virtio_pci-$(CONFIG_VIRTIO_PCI_LEGACY) += virtio_pci_legacy.o > > > > Now I saw that CONFIG_PCI_IOV is not set in the error log so the bellow > should fix it: > > diff --git a/include/linux/pci.h b/include/linux/pci.h > index 060af91bafcd..c519220e8ff8 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -2228,7 +2228,10 @@ static inline int pci_sriov_set_totalvfs(struct > pci_dev *dev, u16 numvfs) > { return 0; } > static inline int pci_sriov_get_totalvfs(struct pci_dev *dev) > { return 0; } > -#define pci_sriov_configure_simple NULL > +static inline int pci_sriov_configure_simple(struct pci_dev *dev, int > nr_virtfn) > +{ > + return -ENOSYS; > +} > static inline resource_size_t pci_iov_resource_size(struct pci_dev > *dev, int resno) > { return 0; } > static inline void pci_vf_drivers_autoprobe(struct pci_dev *dev, bool > probe) { } > > Bjorn, > > WDYT about the above ? > > should I send it to the pci subsystem list ? Yes. I don't apply things that haven't appeared on linux-pci@xxxxxxxxxxxxxxx. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
