On Fri, Jul 1, 2022 at 12:03 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > > On Fri, 1 Jul 2022 10:06:55 +0800 Jason Wang wrote: > > We try using cancel_delayed_work_sync() to prevent the work from > > enabling NAPI. This is insufficient since we don't disable the source > > of the refill work scheduling. This means an NAPI poll callback after > > cancel_delayed_work_sync() can schedule the refill work then can > > re-enable the NAPI that leads to use-after-free [1]. > > > > Since the work can enable NAPI, we can't simply disable NAPI before > > calling cancel_delayed_work_sync(). So fix this by introducing a > > dedicated boolean to control whether or not the work could be > > scheduled from NAPI. > > Hm, does not apply cleanly to net or Linus's tree. May bad, let me post a new version. Thanks > _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization