On Mon, Apr 25, 2022 at 2:27 PM Cindy Lu <lulu@xxxxxxxxxx> wrote:
>
> this patch is to add the support for vdpa tool in vp_vdpa
> here is the example steps
>
> modprobe vp_vdpa
> modprobe vhost_vdpa
> echo 0000:00:06.0>/sys/bus/pci/drivers/virtio-pci/unbind
> echo 1af4 1041 > /sys/bus/pci/drivers/vp-vdpa/new_id
>
> vdpa dev add name vdpa1 mgmtdev pci/0000:00:06.0
>
> Signed-off-by: Cindy Lu <lulu@xxxxxxxxxx>
> ---
> drivers/vdpa/virtio_pci/vp_vdpa.c | 138 +++++++++++++++++++++++-------
> 1 file changed, 106 insertions(+), 32 deletions(-)
>
> diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c
> index cce101e6a940..873402977543 100644
> --- a/drivers/vdpa/virtio_pci/vp_vdpa.c
> +++ b/drivers/vdpa/virtio_pci/vp_vdpa.c
> @@ -32,7 +32,8 @@ struct vp_vring {
>
> struct vp_vdpa {
> struct vdpa_device vdpa;
> - struct virtio_pci_modern_device mdev;
> + /* this is an pointer point to the mdev in vp_vdpa_mgmtdev*/
> + struct virtio_pci_modern_device *mdev;
The code can explain itself, so the comment is redundant.
> struct vp_vring *vring;
> struct vdpa_callback config_cb;
> char msix_name[VP_VDPA_NAME_SIZE];
> @@ -41,6 +42,12 @@ struct vp_vdpa {
> int vectors;
> };
>
> +struct vp_vdpa_mgmtdev {
> + struct vdpa_mgmt_dev mgtdev;
> + struct virtio_pci_modern_device mdev;
I think coupling it with mgmt device is probably not good, any reason
we can't allocate it independently?
Thanks
> + struct vp_vdpa *vp_vdpa;
> +};
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
