On Tue, Apr 19, 2022 at 9:16 PM Hangbin Liu <liuhangbin@xxxxxxxxx> wrote: > > Hi Willem, > > On Tue, Apr 19, 2022 at 09:52:46AM -0400, Willem de Bruijn wrote: > > Segmentation offload requires checksum offload. Packets that request > > OK, makes sense. > > > GSO but not NEEDS_CSUM are an aberration. We had to go out of our way > > to handle them because the original implementation did not explicitly > > flag and drop these. But we should not extend that to new types. > > So do you mean, the current gso types are enough, we should not extend to > handle VLAN headers if no NEEDS_CSUM flag. This patch can be dropped, right? That's right. > Although I don't understand why we should not extend to support VLAN GSO. > I'm OK if you think this patch should be dropped when I re-post patch 1/2 to > net-next. > > Thanks > Hangbin _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
