On 18.01.22 11:43, Michael S. Tsirkin wrote: > On Tue, Jan 18, 2022 at 09:38:21AM +0100, David Hildenbrand wrote: >> On 18.01.22 02:34, Gavin Shan wrote: >>> This enables virtio-mem device support by allowing to enable the >>> corresponding kernel config option (CONFIG_VIRTIO_MEM) on the >>> architecture. >>> >>> Signed-off-by: Gavin Shan <gshan@xxxxxxxxxx> >>> --- >>> drivers/virtio/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig >>> index 34f80b7a8a64..bf3f6ebdaa3b 100644 >>> --- a/drivers/virtio/Kconfig >>> +++ b/drivers/virtio/Kconfig >>> @@ -106,7 +106,7 @@ config VIRTIO_BALLOON >>> config VIRTIO_MEM >>> tristate "Virtio mem driver" >>> default m >>> - depends on X86_64 >>> + depends on X86_64 || ARM64 >>> depends on VIRTIO >>> depends on MEMORY_HOTPLUG >>> depends on MEMORY_HOTREMOVE >> >> With MEMBLOCK_DRIVER_MANAGED in place upstream, kexec should be fine. >> >> >> Can you adjust/rephrase the comment as well? Like >> >> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig >> index 34f80b7a8a64..88028ca01c8f 100644 >> --- a/drivers/virtio/Kconfig >> +++ b/drivers/virtio/Kconfig >> @@ -116,8 +116,9 @@ config VIRTIO_MEM >> This driver provides access to virtio-mem paravirtualized memory >> devices, allowing to hotplug and hotunplug memory. >> >> - This driver was only tested under x86-64, but should theoretically >> - work on all architectures that support memory hotplug and hotremove. >> + This driver was only tested under x86-64 and arm64, but should >> + theoretically work on all architectures that support memory hotplug and >> + hotremove. >> >> If unsure, say M. >> >> >> >> Acked-by: David Hildenbrand <david@xxxxxxxxxx> > > with this: > Acked-by: Michael S. Tsirkin <mst@xxxxxxxxxx> > > I guess I will merge this? It's a small change so - let's go for this > release straight away? Yes, no need to wait for the next cycle. -- Thanks, David / dhildenb _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
