On Tue, Dec 7, 2021 at 10:45 AM Mike Christie <michael.christie@xxxxxxxxxx> wrote: > > The flush after vhost_dev_cleanup is not needed because: > > 1. It doesn't do anything. vhost_dev_cleanup will stop the worker thread > so the flush call will just return since the worker has not device. > > 2. It's not needed. The comment about jobs re-queueing themselves does > not look correct because handle_vq does not requeue work. Similar to the previous patch, I wonder if it's the credit from vhost_dev_cleanup(). Thanks > > Signed-off-by: Mike Christie <michael.christie@xxxxxxxxxx> > --- > drivers/vhost/test.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/vhost/test.c b/drivers/vhost/test.c > index d4f63068d762..57e24eceff27 100644 > --- a/drivers/vhost/test.c > +++ b/drivers/vhost/test.c > @@ -158,9 +158,6 @@ static int vhost_test_release(struct inode *inode, struct file *f) > vhost_test_flush(n); > vhost_dev_stop(&n->dev); > vhost_dev_cleanup(&n->dev); > - /* We do an extra flush before freeing memory, > - * since jobs can re-queue themselves. */ > - vhost_test_flush(n); > kfree(n); > return 0; > } > -- > 2.25.1 > _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
