On Mon, Nov 8, 2021 at 12:15 AM Christophe JAILLET
<christophe.jaillet@xxxxxxxxxx> wrote:
>
> When 'pcim_enable_device()' is used, some resources become automagically
> managed.
> There is no need to call 'pci_free_irq_vectors()' when the driver is
> removed. The same will already be done by 'pcim_release()'.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Acked-by: Jason Wang <jasowang@xxxxxxxxxx>
> ---
> Leaving the 'pci_free_irq_vectors()' call is harmless.
> ---
> drivers/vdpa/alibaba/eni_vdpa.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/vdpa/alibaba/eni_vdpa.c b/drivers/vdpa/alibaba/eni_vdpa.c
> index 12b3db6b4517..3db686436628 100644
> --- a/drivers/vdpa/alibaba/eni_vdpa.c
> +++ b/drivers/vdpa/alibaba/eni_vdpa.c
> @@ -450,11 +450,6 @@ static u16 eni_vdpa_get_num_queues(struct eni_vdpa *eni_vdpa)
> return num;
> }
>
> -static void eni_vdpa_free_irq_vectors(void *data)
> -{
> - pci_free_irq_vectors(data);
> -}
> -
> static int eni_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> {
> struct device *dev = &pdev->dev;
> @@ -488,13 +483,6 @@ static int eni_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> eni_vdpa->vdpa.dma_dev = &pdev->dev;
> eni_vdpa->queues = eni_vdpa_get_num_queues(eni_vdpa);
>
> - ret = devm_add_action_or_reset(dev, eni_vdpa_free_irq_vectors, pdev);
> - if (ret) {
> - ENI_ERR(pdev,
> - "failed for adding devres for freeing irq vectors\n");
> - goto err;
> - }
> -
> eni_vdpa->vring = devm_kcalloc(&pdev->dev, eni_vdpa->queues,
> sizeof(*eni_vdpa->vring),
> GFP_KERNEL);
> --
> 2.30.2
>
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
